-
Notifications
You must be signed in to change notification settings - Fork 573
Fix TokenKey host and user argument order in auth cache - #3028
Open
Hashim1999164 wants to merge 1 commit into
Open
Fix TokenKey host and user argument order in auth cache #3028Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Auth temporary credential helpers built TokenKey positionally as TokenKey(host, user, type), which swapped the dataclass fields. Use keyword arguments so keys match the declared (user, host) layout and OAuth cache entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #2931
TokenKeyis declared as(user, host, tokenType), but the temporary credential helpers inauth/_auth.pybuilt it positionally asTokenKey(host, user, cred_type). That swapped the fields, so ID and MFA cache entries usedUSER:HOST:TOKEN_TYPEwhile OAuth used the intendedHOST:USER:TOKEN_TYPE.This change builds those keys with keyword arguments and updates matching integ cleanup call sites. A unit test asserts store, retrieve, and delete all use
userandhostin the declared order.Note: existing ID/MFA tokens stored under the swapped layout will not be found after upgrade, so users may see one extra authentication prompt while the cache repopulates.