-
Notifications
You must be signed in to change notification settings - Fork 573
Keep custom public PKCE client_id in OAuth authorization code - #3012
Open
Hashim1999164 wants to merge 4 commits into
Open
Keep custom public PKCE client_id in OAuth authorization code #3012Hashim1999164 wants to merge 4 commits into
Hashim1999164 wants to merge 4 commits into
Conversation
Hashim1999164
commented
Sep 1, 2026
Author
I have read the CLA Document and I hereby sign the CLA
Hashim1999164
commented
Sep 2, 2026
Author
recheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #3011
The eligibility check treated a missing client_secret as a reason to replace a supplied client_id with LOCAL_APPLICATION. Public PKCE clients keep the custom client_id, skip HTTP Basic, and send client_id in the token request body.
Test plan
Ran pytest test/unit/test_auth_oauth_auth_code.py and test/unit/test_auth_oauth_credentials.py locally (34 passed).