-
Notifications
You must be signed in to change notification settings - Fork 573
Migrate packaging metadata from setup.cfg to pyproject.toml - #2992
Open
sakshamgoyal-01 wants to merge 1 commit into
Open
Migrate packaging metadata from setup.cfg to pyproject.toml #2992sakshamgoyal-01 wants to merge 1 commit into
sakshamgoyal-01 wants to merge 1 commit into
Conversation
All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.
sakshamgoyal-01
commented
Aug 5, 2026
Author
I have read the CLA Document and I hereby sign the CLA
sakshamgoyal-01
force-pushed
the
migrate-setup-cfg-to-pyproject
branch
from
August 5, 2026 19:49
1932947 to
2285f11
Compare
Move setup.cfg metadata, dependencies, and the nanoarrow extension declaration into pyproject.toml (PEP 621 + setuptools ext-modules). Resolve version from snowflake.connector.version.__version__, make boto3/botocore an opt-in [boto3] extra (remove SNOWFLAKE_NO_BOTO), and keep setup.py only for platform-specific build_ext/build_py logic.
sakshamgoyal-01
force-pushed
the
migrate-setup-cfg-to-pyproject
branch
from
August 5, 2026 20:10
2285f11 to
04057c7
Compare
sakshamgoyal-01
marked this pull request as ready for review
August 5, 2026 20:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
setup.cfgintopyproject.toml(PEP 621 + setuptools).[tool.setuptools.ext-modules]instead ofcythonize().snowflake.connector.version.__version__.boto3/botocoreopt-in via.[boto3](remove default install andSNOWFLAKE_NO_BOTO).setup.pykeeps only platform-specificbuild_ext/build_pylogic. Theif True:wrapper aroundMyBuildExtpreserves the old indentation so the review diff stays easy to read.Test plan
python ci/anaconda/validate_deps_sync.pynanoarrow_arrow_iterator.cpython-*.soSNOWFLAKE_DISABLE_COMPILE_ARROW_EXTENSIONS=1omits that compiled module