Skip to content

Navigation Menu

Sign in
Sign up

SNOW-3008357 add glob escape - #2740

Open
myu65 wants to merge 2 commits into
snowflakedb:main from
myu65:glob-safe-filename
Open

SNOW-3008357 add glob escape #2740
myu65 wants to merge 2 commits into
snowflakedb:main from
myu65:glob-safe-filename

Conversation

@myu65

@myu65 myu65 commented Jan 18, 2026

Copy link
Copy Markdown

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-3008357

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

just add glob escape to file name

  1. (Optional) PR for stored-proc connector:

myu65 requested a review from a team as a code owner January 18, 2026 13:29

github-actions Bot commented Jan 18, 2026
edited
Loading

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

myu65 commented Jan 18, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@myu65 myu65 changed the title (削除) add glob escaoe (削除ここまで) (追記) SNOW-3008357 add glob escape (追記ここまで) Jan 19, 2026
if not os.path.isabs(file_name):
file_name = os.path.abspath(file_name)
safe_file_name = glob.escape(file_name)
files = glob.glob(file_name)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forget change glob.glob(file_name) to glob.glob(safe_file_name)
safe_file_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-turbaszek sfc-gh-turbaszek sfc-gh-turbaszek approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /