-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Update chronological-issues-from-video.md #932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@PatrickAlphaC Please give it a check this is valuable information, thanks again @n4n0b1t3 !!
Woah.... this is super weird. Do you have any docs that show that these two should be different? It could be a weird ganache thing....
Also, you'd doing this great! This is exactly how one would contribute. Could you share some other docs that show that ganache is wonnkey?
Hmm, actually Ganache behaves correctly towards the specification. I even have the suspicion that Ganache has taken two different values on purpose. After all, it is a development tool and so the developers can learn that these are two different values.
I had referred to the following article: https://besu.hyperledger.org/en/stable/Concepts/NetworkID-And-ChainID/
Just now, I took a look at the ETH chain specification: https://openethereum.github.io/Chain-specification.html
ChainID was introduced after the Network ID, the default value for ChainID is equal to Network ID (but can be different). Here is the text from the specification.
"chainID" chain identifier, was introduced in EIP-155 to prevent replay attacks between the main ETH and ETC chains, which both have a networkID of 1. ChainID is an additional way to tell chains apart. Subsequent to EIP-155, ETH had a chainID of 1, while ETC had a chainID of 61. networkID and chainID are required for the chain to operate in general - e.g. it’s required when signing transactions. Default value is equal to networkID.
Lovely.
Thank you for this!
I didn't know that, learn something new everyday :)
Great first contribution!!
It is fun to work on the project and I learn a lot! Thank you very much, this is a great team.
commit c2826e1 Merge: c6d8229 d330163 Author: Patrick Collins <54278053+PatrickAlphaC@users.noreply.github.com> Date: Thu Feb 10 19:35:06 2022 -0500 Merge pull request smartcontractkit#858 from cromewar/cytools adding cytools error solution commit c6d8229 Merge: 167ede3 28723cc Author: Patrick Collins <54278053+PatrickAlphaC@users.noreply.github.com> Date: Mon Feb 7 21:32:06 2022 -0500 Merge pull request smartcontractkit#932 from n4n0b1t3/patch-1 Update chronological-issues-from-video.md commit 28723cc Author: Patrick Collins <54278053+PatrickAlphaC@users.noreply.github.com> Date: Mon Feb 7 21:32:02 2022 -0500 Update chronological-issues-from-video.md commit e036f87 Author: Patrick Collins <54278053+PatrickAlphaC@users.noreply.github.com> Date: Mon Feb 7 21:31:57 2022 -0500 Update chronological-issues-from-video.md commit 167ede3 Merge: d64d413 ee54f33 Author: Patrick Collins <54278053+PatrickAlphaC@users.noreply.github.com> Date: Sat Feb 5 19:10:32 2022 -0500 Merge pull request smartcontractkit#927 from freddie71010/patch-1 Update README.md - Add a link to "chronological-issues-from-video.md" that describes known issues with the video commit ee54f33 Author: Freddie von Stange <freddie71010@users.noreply.github.com> Date: Wed Feb 2 14:30:28 2022 -0500 Update README.md Add a link to "chronological-issues-from-video.md" that describes known issues with the video commit dbd35f5 Author: n4n0b1t3 <32838961+n4n0b1t3@users.noreply.github.com> Date: Wed Feb 2 15:11:32 2022 +0100 Update chronological-issues-from-video.md commit d330163 Author: cromewar <vasiliy@cromewar.com> Date: Mon Jan 24 16:36:57 2022 -0500 adding cytools error solution commit d64d413 Author: Patrick Collins <54278053+PatrickAlphaC@users.noreply.github.com> Date: Mon Jan 17 18:47:52 2022 -0500 Update for broken repay function commit 8552910 Merge: 1f09826 d51f623 Author: Patrick Collins <54278053+PatrickAlphaC@users.noreply.github.com> Date: Sun Jan 16 20:20:25 2022 -0500 Merge pull request smartcontractkit#643 from jethr0null/main Add colorized brackets issue commit 1f09826 Merge: e13aede de8a23f Author: Patrick Collins <54278053+PatrickAlphaC@users.noreply.github.com> Date: Sun Jan 16 20:19:53 2022 -0500 Merge pull request smartcontractkit#776 from chalex-eth/main Update README.md commit de8a23f Author: chalex.eth <43524913+chalex-eth@users.noreply.github.com> Date: Thu Jan 13 10:13:22 2022 -0800 Update README.md commit d51f623 Author: jethr0null <mnikki137@gmail.com> Date: Mon Dec 27 13:54:11 2021 -0700 Add colorized brackets issue
Content update for video issue page containing a note about the confusion between network ID and chain ID which often leads to unexpected errors and is the source of quite a few requests in the discussions.
I was asked by @cromewar to contribute to this information. Never contributed to an open GitHub project before, hope I am doing this is correct. If not please give me a hint.