-
Notifications
You must be signed in to change notification settings - Fork 317
Open
Conversation
This commit adds support for ML-DSA keys on ca, certificate, and key commands. SSH and JOSE commands doesn't yet support ML-DSA keys.
@github-actions
github-actions
Bot
added
the
needs triage
Waiting for discussion / prioritization by team
label
Sep 4, 2026
maraino
marked this pull request as ready for review
September 4, 2026 23:16
hslatman
hslatman
reviewed
Sep 6, 2026
Comment on lines
+40
to
+50
: Create an **RSA** key pair
**ML-DSA-44**
: Create a ML-DSA key pair using the **ML-DSA-44** parameter set.
**ML-DSA-65**
: Create a ML-DSA key pair using the **ML-DSA-65** parameter set.
**ML-DSA-87**
: Create a ML-DSA key pair using the **ML-DSA-87** parameter set.
`,
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
: Create an **RSA** key pair
**ML-DSA-44**
: Create a ML-DSA key pair using the **ML-DSA-44** parameter set.
**ML-DSA-65**
: Create a ML-DSA key pair using the **ML-DSA-65** parameter set.
**ML-DSA-87**
: Create a ML-DSA key pair using the **ML-DSA-87** parameter set.
`,
: Create an **RSA** key pair
**ML-DSA-44**
: Create an ML-DSA key pair using the **ML-DSA-44** parameter set.
**ML-DSA-65**
: Create an ML-DSA key pair using the **ML-DSA-65** parameter set.
**ML-DSA-87**
: Create an ML-DSA key pair using the **ML-DSA-87** parameter set.
`,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for ML-DSA keys on ca, certificate, and key commands. SSH and JOSE commands doesn't yet support ML-DSA keys.
This PR also updates minimum version of Go to 1.26 and modernizes go with
go fix ./...