Skip to content

Navigation Menu

Sign in
Sign up

Add --confirm flag to require agent confirmation - #1654

Open
kavix wants to merge 3 commits into
smallstep:master from
kavix:master
Open

Add --confirm flag to require agent confirmation #1654
kavix wants to merge 3 commits into
smallstep:master from
kavix:master

Conversation

@kavix

@kavix kavix commented Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown

This PR adds a new --confirm flag to step ssh login, step ssh proxycommand, and step ssh certificate.
Solve #1611
When used, this flag adds the generated SSH certificate to the agent with the 'confirmation required' bit set, requiring user interaction (typically a prompt from the SSH agent) for every use of the key.

Changes:

  • Added WithConfirmBeforeUse AgentOption in internal/sshutil.
  • Updated Agent.AddCertificate to support the new option.
  • Added the --confirm flag to relevant SSH commands.
  • Added unit tests for the new option handling.

CLAassistant commented Jun 13, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions Bot added the needs triage Waiting for discussion / prioritization by team label Jun 13, 2026
@hslatman hslatman changed the title (削除) feat(ssh): add --confirm flag to require agent confirmation (削除ここまで) (追記) Add --confirm flag to require agent confirmation (追記ここまで) Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /