Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Oct 30, 2018. It is now read-only.

Increase SLKTextView's influence over calculating its height.#653

Open
lukkas wants to merge 3 commits into
slackhq:master from
lukkas:master
Open

Increase SLKTextView's influence over calculating its height. #653
lukkas wants to merge 3 commits into
slackhq:master from
lukkas:master

Conversation

@lukkas

@lukkas lukkas commented Nov 16, 2017
edited
Loading

Copy link
Copy Markdown
  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've added a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've listed my changes on the [Changelog(https://github.com/slackhq/SlackTextViewController/blob/master/CHANGELOG.md) file.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Change doesn't affect the functionality in any way. It moves SLKTextView height calculation logic to SLKTextView class itself. This adds flexibility when subclassing SLKTextView.
Example:
When adding custom line spacing using NSAttributedString and NSParagraphStyle to text in text view, there is currently no way to change its height in order to accommodate text formatted that way.

@dzenbot dzenbot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please update the recent conflict.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@dzenbot dzenbot dzenbot approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /