This repository was archived by the owner on Oct 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fixed placeholder label layout - it should calculate bounds considering label width, not bounds width#617
Open
akievsk wants to merge 1 commit into
Open
Fixed placeholder label layout - it should calculate bounds considering label width, not bounds width #617akievsk wants to merge 1 commit into
akievsk wants to merge 1 commit into
Conversation
...ng label width, not bounds width
@dzenbot
dzenbot
changed the title
(削除) Fixed placeholder label layout - it should calculate bounds consideri... (削除ここまで)
(追記) Fixed placeholder label layout - it should calculate bounds considering label width, not bounds width (追記ここまで)
Oct 26, 2017
dzenbot
commented
Nov 1, 2017
@akievsk did you find any ways to reproduce the issue on the sample project?
I haven't experienced any issues with the label. Even tho your changes seem logical, I would first want to verify the fix.
akievsk
commented
Nov 2, 2017
Author
screen shot 2017年11月02日 at 9 42 02 am
Here is the sample how this bug can be reproduced. I changed placeholder to something "very long" and changed height of text view to be more than one line
dzenbot
commented
Nov 2, 2017
Great. This is useful, thanks. Will review this soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
PR Summary
Fixed placeholder label layout - it should calculate bounds considering label width, not bounds width