Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Stage/Working Color highlight in FilePanel #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yinameah wants to merge 1 commit into sindrets:main
base: main
Choose a base branch
Loading
from Yinameah:main

Conversation

Copy link

@Yinameah Yinameah commented Apr 28, 2024

Hello,

I really like your plugin, it's straightforward and exactly what I was looking for my git integration.

I have one minor annoyance : I don't like that "Changes" and "Staged changes" appear with the same highlight. It confused me a few time when one of the two list isn't present, I would find clearer something green-ish for the Staged changes.

image

I thought I could just come up with a hi link of sorts, but since it's the same hl group for both, there is not much I could do without changing the DiffView source.

The current Pull Request is just a first step to show what I'm talking about. It would allows for colors scheme implementer (or myself in my config) to tweak the color of each Title afterwards.
My plan was to give a specific name for each Title, and then link all theses to a generic name, so that it doesn't break any existing behavior, or something alike.
However, my understanding of the hi link conventions is quite limited, and I couldn't figure how the DiffviewFilePanelTitle hl group even ends up being red in my config. I tested with a few colorschemes, and the titles would have different colors, without me being able to get how this ends up to be.

If somebody would be able to point me in the right direction, I would be very grateful to learn something and elaborate on the PR.

Also, feel free to close this issue if you consider that it's too minor to be worth the effort.
All the best and thanks for the great work

kevintraver reacted with thumbs up emoji
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /