Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

Add fullscreen bypass support#808

Open
aedalzotto wants to merge 8 commits into
sharpbracket:master from
aedalzotto:fullscreen
Open

Add fullscreen bypass support #808
aedalzotto wants to merge 8 commits into
sharpbracket:master from
aedalzotto:fullscreen

Conversation

@aedalzotto

@aedalzotto aedalzotto commented Mar 3, 2021
edited
Loading

Copy link
Copy Markdown

This pull request adds support for automatically disabling redshift when a fullscreen application is detected, solving issue #548.
There is a possibility to disable this function from command line with the option "-f 0".

Differing from #407, this implements the function in the redshift daemon.
It does not use the EWMH because it is not reliable enough (confirmed poor compatibility with i3).
No implementation has been made for Windows yet, but the code should still compile.


EDIT:
Also, there is a SIGUSR2 and a checkbox in redshift-gtk to disable this function at any time.


EDIT:
Multi-monitor support is a bit tricky and must be decided how it should work before it is developed.
I think it must check if the focused window is fullscreen in its display and disable redshift for all displays, or make a per-display control, but I don't know if this is possible.

jgandert and nahuel-soldevilla reacted with hooray emoji
Comment thread src/signals.c
disable = 1;
}

/* Signal handler for disabling the fullscreen detector signal */

@CameronNemo CameronNemo Mar 3, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redshift is in sore need of a control interface other than signals.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@CameronNemo CameronNemo CameronNemo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /