-
Notifications
You must be signed in to change notification settings - Fork 25
print out userProvidedSrc instead #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PWhiddy
PWhiddy
reviewed
May 30, 2022
@@ -205,7 +205,7 @@ export function sculptToGLSL(userProvidedSrc) {
userProvidedSrc = replaceMathOps(userProvidedSrc);
if (debug) {
console.log('tree', tree);
console.log('userProvidedSrc', userProvidedSrc);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally this would have printed the parsed source tree that is generated by esprima. I'm not sure if printing the user source here is that helpful. Tbh the debug flag has not really been maintained since it was created and we might want to completely visit it or just remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debug mode, there would be an error say that parameter
treeis not found. I believe the original scriptconsole.log('tree', tree)is to print out the return result inreplaceMathOpsfunction. So I replace it touserProvidedSrcinstead.