-
Notifications
You must be signed in to change notification settings - Fork 25
Make p5.js target work with standalone P5 #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P5 functions are available as globals in their web editor but not necessary the case in all P5 environments. Modify the P5 draw function to make it work in environments where those functions aren't global.
Looks good to me! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P5 functions are available as globals in their web editor but not necessary the case in all P5 environments.
Modify the P5 draw function to make it work in environments where those functions aren't global.
I'm sorry, but I am not very good at Javascript build systems and though I tried the yarn => yarn build => yarn link => yarn link shader-park-core workflow it didn't work, I was getting this error exports is not defined which I am not sure about, but I doubt that's caused by my code changes.