-
Notifications
You must be signed in to change notification settings - Fork 79
chore: 🤖 make parking_lot dependency optional
#265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🤖 make parking_lot dependency optional
#265
Conversation
IWANABETHATGUY
commented
Oct 11, 2022
Here is the benchmark for current std::sync::Mutex rust-lang/rust#95035 (comment), It is 10 times faster than parking_lot::Mutex when the extreme contention scenario, although not all platforms have been migrated to Mutex with futex based ones (e.g. MacOs ), more details you could refer to rust-lang/rust#93740
bors-servo
commented
Feb 20, 2023
☔ The latest upstream changes (presumably #268) made this pull request unmergeable. Please resolve the merge conflicts.
Uh oh!
There was an error while loading. Please reload this page.
Summary
parking_lotis not always the best choice after rust stable 1.62 https://blog.rust-lang.org/2022/06/30/Rust-1.62.0.html#thinner-faster-mutexes-on-linuxparking_lotan optional dependencyparking_lot_supportto let user enable the optional dependencyparking_lotparking_lot_supportto the default_features list to avoid breaking changes.