-
Notifications
You must be signed in to change notification settings - Fork 145
Comments
Conversation
LastLeaf
commented
Jun 7, 2024
It seems that the changes are not complete. I still find some deps need changes or default-features = false .
olanod
commented
Jun 7, 2024
I tested it with cargo build --no-default-features and cargo test with default features on purpose to use std. Is that what you tried?
LastLeaf
commented
Jun 7, 2024
I tested it with
cargo build --no-default-featuresandcargo testwith default features on purpose to use std. Is that what you tried?
I built with --target armv7a-none-eabi (which does not have a std) and fixed some of the compilation errors. You can take a look at my branch. It also requires a dep change.
olanod
commented
Jun 10, 2024
Merged your branch as your PR for the dependency was merged and released.
LastLeaf
commented
Jun 17, 2024
More changes are needed in the cssparser-color crate. My branch has been updated.
@emilio
emilio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok, but can you rebase and add the license headers? Thanks
b96cd47 to
0d98d46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I missed this. It seems this dependency should be optional, and only enabled if std is disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be a typo. Should call into trunc function not round functions
Make crate no_std while keeping it backwards compatible with a default
stdfeature enabled(only used to impl Error for ParseError).