-
Notifications
You must be signed in to change notification settings - Fork 207
Add sourcelink to nuget package #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
related to #203
Sorry about the long delay reviewing this, I'll aim to get back around to it soon.
@nblumhardt Proper SourceLink support would be handy in v3.
ping @nblumhardt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trivial changes suggested; thanks @dakhraui !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These can go in the long list of properties already present above; we only tend to use property groups when different conditions need to be applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IsPackable already defaults to true so can be removed from this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed since NET8.
To improve development/debugging experience