-
Notifications
You must be signed in to change notification settings - Fork 147
Updated SqlClient to 6.1.1 and other deps and removed workaround for issue #624 #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated SqlClient to 6.1.1 and other deps and removed workaround for issue #624 #634
Conversation
@ckadluba
ckadluba
commented
Aug 20, 2025
- Updated SqlClient to 6.1.1 and removed Azure.Identity workaround for issue Security issue in dependency Microsoft.Identity.Client #624
- Updated all dependencies except .NET 9 NuGets
- Bumped major version to 9.0.0
Azure.Identity dependency was added as a workaround to fix security issue serilog-mssql#624 caused by SqlClient. Now SqlClient was updated to 6.1.1 which does not cause the issue anymore and Azure.Identity could be removed again.
After SqlClient update from 5.2.3 to 6.1.1 we move the sink to major version 9.
@Copilot
Copilot
AI
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Serilog.Sinks.MSSqlServer package to version 9.0.0 with major dependency updates, particularly upgrading Microsoft.Data.SqlClient from 5.2.3 to 6.1.1 and removing the Azure.Identity workaround that was previously needed for issue #624.
- Updated Microsoft.Data.SqlClient from 5.2.3 to 6.1.1 and removed Microsoft.Identity.Client dependency
- Upgraded multiple development and testing dependencies including BenchmarkDotNet, FluentAssertions, Moq, and Serilog
- Bumped the package version from 8.2.3 to 9.0.0 to reflect breaking changes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Serilog.Sinks.MSSqlServer/Serilog.Sinks.MSSqlServer.csproj | Updated version prefix to 9.0.0 and removed Microsoft.Identity.Client package reference |
| Directory.Packages.props | Updated versions for SqlClient, testing frameworks, and other dependencies |
| CHANGES.md | Added changelog entry documenting the major version update and dependency changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PackageValidationBaselineVersion should be updated to reflect the new major version. Consider updating it to 9.0.0 to maintain consistency with the new VersionPrefix.
Copilot uses AI. Check for mistakes.