-
-
Notifications
You must be signed in to change notification settings - Fork 527
Open
Conversation
Replace fs-extra dependency with native Node.js fs module equivalents:
- fs-extra copySync → recursive copy using fs.copyFileSync + fs.readdirSync
- fs-extra copy → fs.copyFile (callback-based)
- fs-extra mkdirpSync → fs.mkdirSync with { recursive: true }
All replacement APIs are available in Node.js 10+, matching the
project's minimum engine requirement.
Part of the e18e ecosystem cleanup initiative.
See e18e/ecosystem-issues#33
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@roli-lpci
roli-lpci
force-pushed
the
chore/remove-fs-extra
branch
from
February 28, 2026 00:54
3d273e7 to
9fcb4e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
fs-extradependency with nativenode:fsequivalentsfs-extraand its transitive dependencies (at-least-node,jsonfile,universalify) from the dependency treeChanges
src/helpers/asset-helper.js— Replacefs-extraimport withfs;copySyncwith a recursive copy helper usingfs.copyFileSync/fs.readdirSync/fs.mkdirSync;mkdirpSyncwithfs.mkdirSync({ recursive: true })test/support/helpers.js— Replacefs-extraimport withfs;copywithfs.copyFile;mkdirpSyncwithfs.mkdirSync({ recursive: true })package.json— Removefs-extrafrom dependenciespackage-lock.json— Regenerated withoutfs-extraand its transitive depsTesting
npm run lintpassesnpm run buildpassesmodel:createwith complex enum attributes, unrelated to this change)Part of the e18e ecosystem cleanup initiative.