-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add ipsec icv #4902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Add ipsec icv #4902
+99
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When icv_size is set to 8 or 12, the encrypted packet should contain a truncated ICV of that length. Previously, the implementation always defaulted to the full 16-byte ICV for AES-GCM, ignoring the configured truncation. This change ensures: 1. Encryption truncates the generated tag to the requested icv_size using the Cipher API. 2. Decryption correctly verifies packets with truncated tags using the Cipher API. Signed-off-by: Iman Afaneh <iafaneh@nvidia.com>
Signed-off-by: Iman Afaneh <iafaneh@nvidia.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #4902 +/- ## ======================================= Coverage 80.84% 80.84% ======================================= Files 369 369 Lines 90968 90989 +21 ======================================= + Hits 73544 73563 +19 - Misses 17424 17426 +2
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
tox)fixes #xxx