Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Make navbar sticky #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@sinharaksh1t sinharaksh1t commented Sep 18, 2024 •
edited
Loading

Resolves #331

Demo (GIF) for Before vs. After:

Before

leetcode patterns before

After

leetcode patterns after

Copy link
Owner

@seanprashad seanprashad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you opening a PR for this @sinharaksh1t! Everything looks good to me 👍🏽

sinharaksh1t reacted with heart emoji
@seanprashad seanprashad merged commit ce00350 into seanprashad:main Sep 19, 2024
Copy link
Contributor Author

Thank you for the quick merge, @seanprashad!

I'm curious what is the CI/CD pipeline like? Do the changes in main branch get auto deployed or do you do it manually?

Copy link
Owner

They currently don't get autodeployed via the github-pages GitHub Action - this is something I should definitely look into because I remember it was working previously.

I've just manually kicked off a deployment - you should see the changes reflected in ~10 minutes or so!

Copy link
Contributor Author

Wonderful, thanks a lot! :D

@sinharaksh1t sinharaksh1t deleted the sinharaksh1t/make-navbar-sticky branch January 13, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanprashad seanprashad seanprashad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep Navigation bar stuck to the top even while scrolling

AltStyle によって変換されたページ (->オリジナル) /