-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fixed randomQuestions - now it uses filtered questions #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seanprashad
merged 1 commit into
seanprashad:main
from
idsulik:random-picker-select-in-filtered-rows
Dec 2, 2023
Merged
Fixed randomQuestions - now it uses filtered questions #295
seanprashad
merged 1 commit into
seanprashad:main
from
idsulik:random-picker-select-in-filtered-rows
Dec 2, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanprashad
seanprashad
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for working on this @idsulik!
@seanprashad thank you for the great tool!
p.s. could you please deploy this changes?
This should be deployed now @idsulik - sorry about that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you filter rows using different filters and click on "Try a random question" it picks depending on all/checked/unchecked filter, but now it picks only within the rows the user see right now, so it considers all filters