-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Generated updated questions json and commit #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@leo-step
leo-step
commented
Jul 31, 2022
- Store question data in json format
- Cron job script reads and updates questions json
- Sets "updated" field to current datetime
- Commits the changes back into the repository
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're on a roll @leo-step! Thank you once again for helping implement this - I know it'll definitely be appreciated by others for sure.
Everything is looking good - I think we should handle the case where questions.json isn't able to be opened/read.
cron/update_questions.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it probably makes more sense to just have the slug for url since each URL is prefixed with https://leetcode.com/problems/
cron/update_questions.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to have an except clause incase questions.json can't be opened/found
cron/update_questions.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make this small change here and in other relevant places? I think it'll help make reading the code a little easier!