Vite 6 is recommended

@git-no Can you add the pnpm-lock.yaml after a pnpm install?

⚠️ No Changeset found

Latest commit: e233a2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sdorra pnpm-lockfile is now integrated.

My build locally failed with

samples-arktype:build: sh: Zeile 1: content-collections: Kommando nicht gefunden.
samples-xml:build: sh: Zeile 1: content-collections: Kommando nicht gefunden.
samples-cli:build: sh: Zeile 1: content-collections: Kommando nicht gefunden.
samples-arktype:build: ELIFECYCLE Command failed.
samples-xml:build: ELIFECYCLE Command failed.
samples-cli:build: ELIFECYCLE Command failed.
samples-valibot:build: 
samples-valibot:build: > samples-valibot@0.1.0 build /Users/lukas/code/labs/svelte-content-collections/samples/valibot
samples-valibot:build: > content-collections build
samples-valibot:build: 
@content-collections/remix-vite:build: cache miss, executing 2d16bb4e9a8811e9
@content-collections/vinxi:build: cache miss, executing 29946ae7386e1a66
@content-collections/remix-vite:build: 
samples-valibot:build: sh: Zeile 1: content-collections: Kommando nicht gefunden.
samples-valibot:build: ELIFECYCLE Command failed.
@content-collections/vinxi:build: 
samples-xml:build: ERROR: command finished with error: command (/Users/lukas/code/labs/svelte-content-collections/samples/xml) /Users/lukas/Library/pnpm/.tools/pnpm/8.15.8/bin/pnpm run build exited (1)
@content-collections/vinxi:build: 
@content-collections/remix-vite:build: 
samples-xml#build: command (/Users/lukas/code/labs/svelte-content-collections/samples/xml) 
 Tasks: 8 successful, 15 total
Cached: 0 cached, 15 total
 Time: 5.133s 
Failed: samples-xml#build
 ERROR run failed: command exited (1)
 ELIFECYCLE Command failed with exit code 1.

@sdorra Are there any plans to update Vite to version 6 in the repository?

Are there any plans to update Vite to version 6 in the repository?

No concrete plans yet. Once I finish the work on #471 and then #494, I will make the long-overdue upgrades to Next and Vite. For Vite, we need to ensure compatibility with v5 and v6.

My build locally failed with

The problem is that these tests use the content-collections CLI, which must be built first. To test a fresh clone of content-collections, follow these steps:

# install dependencies
pnpm install
# build the cli
pnpm build --filter=@content-collections/cli
# ensure the cli is linked
pnpm install
# build all packages
pnpm build
# run the tests
pnpm test

This should probably be in the README 🤔

The ci process still ends with the following error:

ERR_PNPM_OUTDATED_LOCKFILE Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with samples/svelte-kit/package.json

Have you done a pnpm install on the root of the monorepo?

@sdorra "Please keep the fixed versions. "

I do not get it? What do you like to have in package.json, my version or the previous version with Vite 5?

Just pnpm build did not work.
Building worked by following your steps.
But still pnpm test at the end fails.

You have changed the version of the @content-collections/* packages to workspace:*, which is incompatible with the sparse checkout of StackBlitz.

Please retain the old versions of the @content-collections/* packages. The other packages can be upgraded. After reverting the versions, run pnpm install on the root package.json of the monorepo, and then commit the package.json and pnpm-lock.yaml.

I am currently not at home and will return on Sunday. I will review the failing tests then.

I've added some styling and sample posts. I will update the tests tomorrow, and then we can merge the PR.

@git-no i've updated the sample to match the look and feel of the other (newer) samples. The build and the tests are working now. But i've noticed that every svelte component i've used inside markdown is wrapped in a p tag. Is there a way to get rid of the p?

I will check next week.

@sdorra
I can not reproduce the issue you mentioned. My tests worked as expected:

1. A Svelte component within a text is included in the <p>.
2. A Svelte component at line start is integrated without <p>.

Do you have an example / repository?

Do you have an example / repository?

Yeah, this pull request. Each MD file uses a different Svelte component and all of them a wrapped with a p tag.