-
Notifications
You must be signed in to change notification settings - Fork 489
Updates in IT translations#1078
Conversation
serhii73
commented
Oct 7, 2022
Thank you for your PR @federicodilo
Could you please add some tests to this PR that cover these changes? Thanks in advance.
ghost
commented
Oct 7, 2022
It should be enough, please feel free to tell me if it's not :)
I have run the tests and it seems to work, it is possible to merge at will.
Gallaecio
commented
Oct 24, 2022
Could you keep the extra comma at the end of lists in Python files? Unlike in JSON, in Python it is allow and even encouraged. And you seem to have edited an unrelated (Ukranian) file making that change (maybe it was your IDE making that change automatically?).
This reverts commit 36aa115.
Well the edits on Ukrainian file were added from IDE to do not overwrite the changes not done by me.
I've reinserted the commas to uniform the files; still it fails to compile though.
Any idea? :)
Gallaecio
commented
Oct 24, 2022
The JSON file cannot have the extra comma, that is a JSON syntax error. Only Python allows the extra comma.
serhii73
commented
Nov 11, 2022
Hi @federicodilo
Could you please resolve the conflicts? Thanks in advance.
Gallaecio
commented
Nov 14, 2022
If you are not familiar with merge conflicts, I recommend reading the GitHub docs about them.
Uh oh!
There was an error while loading. Please reload this page.
Added few other translations to which replace all previous Italian PRs
Mergeable after #1049