-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Conversation
@quinnmil
quinnmil
force-pushed
the
811-backwards-compatible-ignore
branch
from
May 6, 2025 19:46
1145c19 to
5e62200
Compare
quinnmil
commented
May 6, 2025
Contributor
Author
Realized that the changes here are redundant. This has already been supported via this:
self.ignore_endpoints = set( config.value("ignore_endpoints") + config.value("ignore") )
So we're removing extra logic, but leaving in the new test.
@quinnmil
quinnmil
force-pushed
the
811-backwards-compatible-ignore
branch
from
May 6, 2025 20:53
5e62200 to
c85f0be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ignorevalue, we weren't checking for this in theany_samplingcheck.