Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix imglib2-style indentation and spaces in try with resources statement#9

Merged
ctrueden merged 1 commit intomaster from
fix-imglib2-try-with-resources-aligment
Feb 15, 2023
Merged

Fix imglib2-style indentation and spaces in try with resources statement #9
ctrueden merged 1 commit intomaster from
fix-imglib2-try-with-resources-aligment

Conversation

@maarzt
Copy link
Collaborator

@maarzt maarzt commented Feb 10, 2023

Sorry but I missed these problems when changing the imglib2 coding style.
I found them just now, while looking at the scijava-coding-style.

So here are the changes made by this PR:

  • Undo unintentional change to the setting "alignment_for_resources_in_try" (has basically no effect, but 120 is wrong, it was introduced as a mixup with the line length. The meaning of these values is not clear to me. They are "magical nunbers")
  • Insert spaces inside the parenthesis of a try with resources statement. This way it's consistent with the formatter of if, for, while-statements, etc.

...ment
Undo unintentional change to property "alignment_for_resources_in_try".
Insert spaces inside the parenthesis of a try with statement.
@ctrueden ctrueden merged commit e5b1ff4 into master Feb 15, 2023
@ctrueden ctrueden deleted the fix-imglib2-try-with-resources-aligment branch February 15, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /