-
Notifications
You must be signed in to change notification settings - Fork 6
[MarkAPI-122] feat: add PubMed/PMC XML generation for XML documents - #124
Open
Rossi-Luciano wants to merge 1 commit into
Open
[MarkAPI-122] feat: add PubMed/PMC XML generation for XML documents #124Rossi-Luciano wants to merge 1 commit into
Rossi-Luciano wants to merge 1 commit into
Conversation
Add models, tasks, admin views and forms to upload an XML document and convert it to PubMed/PMC XML formats independently of other workflows, plus a "Last error" column in the XML Documents list to surface conversion errors. Also fixes a double-serialization bug where generate_pubmed_for_xml_document/generate_pmc_for_xml_document wrote xml_utils.tostring(...) over strings already returned by packtools' pipeline_pubmed/pipeline_pmc. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
generate_pubmed_for_xml_document/generate_pmc_for_xml_documentwere callingxml_utils.tostring(...)on strings already returned by packtools'pipeline_pubmed/pipeline_pmc, causingTypeError: Type 'str' cannot be serialized.(logged as "Unknown Error").Test plan
python manage.py test xml_manager— 46 tests, same 8 pre-existing unrelated failures intest_sps_package_validation.py(celery broker/test-db isolation issue), no new regressions.S1984-92302025000100304.xml) that previously failed with "Unknown Error".Issue
#122
🤖 Generated with Claude Code