-
Notifications
You must be signed in to change notification settings - Fork 5
Reveal Mailroom posts without overriding a hidden sidebar - #328
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mailroom posts could arrive while the right sidebar remained hidden by default, leaving people unaware of the room. The workspace now reveals the sidebar when enabled Mailroom content becomes available, including when opening a workspace that already has mail.
An explicit visibility choice wins: hiding the sidebar prevents later mail, workspace switches, and relaunches from reopening it. Automatic opening does not write a user preference. Existing saved visibility and Mailroom fold choices remain respected.
Validation: macOS app build and full test suite passed (1,695 tests across 180 suites, xcodebuild exit 0). New regression coverage exercises first arrival, existing content, no automatic preference write, hiding followed by further mail, reopening a workspace, and manual re-showing. SwiftLint, repository Swift formatting, and git diff checks passed.