-
Notifications
You must be signed in to change notification settings - Fork 59
fix(agentex): Slack gateway — empty ack body + clearer breadcrumb attribution - #406
fix(agentex): Slack gateway — empty ack body + clearer breadcrumb attribution #406michael-chou359 wants to merge 1 commit into
Conversation
...ribution
- Slack renders a bare `{}` JSON body as a stray message, so the ack-only
responses (modal opened, view_submission close, ignored interactions) now
send a truly EMPTY 200 via a _slack_ack helper instead of returning `{}`.
- Breadcrumb footer reads "<@user> asked *agent*" instead of the ambiguous
"via <@user> through *agent*" (via/through were synonyms back-to-back).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
✱ Stainless preview builds
This PR will update the agentex-sdk SDKs with the following commit messages.
openapi
fix(types): remove response schemas from slack commands and interactions
python
chore(internal): regenerate SDK with no functional changes
typescript
chore(internal): regenerate SDK with no functional changes
Edit this comment to update them. They will appear in their respective SDK's changelogs.
✅ agentex-sdk-openapi studio · code · diff
Your SDK build had at least one new note diagnostic, which is a regression from the base state.
generate ✅New diagnostics (2 note)
✅ agentex-sdk-typescript studio · code · diff
Your SDK build had at least one new note diagnostic, which is a regression from the base state.
generate ⚠️→build ⏭️→lint ⏭️→test ✅New diagnostics (2 note)
✅ agentex-sdk-python studio · code · diff
Your SDK build had at least one new note diagnostic, which is a regression from the base state.
generate ⚠️→build ⏭️→lint ⏭️→test ✅New diagnostics (2 note)
This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026年08月17日 20:05:24 UTC
Uh oh!
There was an error while loading. Please reload this page.
Two small Slack-gateway polish fixes.
{}stray messageSlack renders a bare
{}JSON body as a stray message in the channel. The ack-only responses (modal opened,view_submissionclose, ignored interactions) were returning{}, so Slack posted junk. Added a_slack_ackhelper: an empty result → a truly empty 200 body; a non-empty result → JSON as before. Applied to/slack/commandsand/slack/interactions(events keep their JSON — theurl_verificationchallenge needs it, and events aren't user-facing).Breadcrumb wording
The
/agentsbreadcrumb footer saidvia <@user> through *agent*— "via" and "through" are synonyms back-to-back, which reads as word soup. Now:<@user> asked *agent*(e.g. "@michaelchou asked golden-agent").Testing
_slack_ackunit test (empty → empty 200 body, non-empty → JSON); full Slack gateway suite green; ruff clean.🤖 Generated with Claude Code
Greptile Summary
The PR changes Slack command and interaction acknowledgements so empty results produce a truly empty HTTP 200 response while non-empty results remain JSON, and clarifies modal breadcrumb attribution.
/agentsbreadcrumb footer without changing its identity or routing behavior.Confidence Score: 5/5
The PR appears safe to merge with no concrete changed-code failure identified.
All current slash-command and interaction return paths align with the new empty-versus-JSON acknowledgement behavior, and the breadcrumb change is presentation-only.
Important Files Changed
_slack_ackand consistently maps all current empty handler results to bodyless 200 responses while retaining JSON for actionable Slack payloads.Responsereturn type.Reviews (1): Last reviewed commit: "fix(agentex): Slack gateway — empty ack ..." | Re-trigger Greptile
Context used (3)