-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Trap Ctrl-C in the REPL: if no command is running clear the prompt, if some command is running ask for confirmation before exiting #24127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scala> while true do | Thread.sleep(1000) | println("still alive!") | still alive! still alive! ^C Interrupting running thread, Ctrl-C again to terminate the REPL Process java.lang.InterruptedException: sleep interrupted at java.base/java.lang.Thread.sleep(Native Method) ... 32 elided scala>
Nice!
(削除) the double Ctl+c doesn't quit for me but keeps resetting the prompt (削除ここまで)
Edit: it has to be a true infinite loop, with no yielding, for double interrupt to work (so no sleep)
Ctrl-C only exits the process when it is running code that it is unable to interrupt. Doesn't need to be infinite, as long as it's running: the first Ctrl-C will ask for confirmation, the second Ctrl-C will exit the process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This ports over one of the other Ammonite features to the Scala 3 REPL, making it behave much more similarly to other prompt environment (Bash, Python, etc.):
Ctrl-Cjust resets the prompt without exitingCtrl-Cfirst interrupts the thread to try and force a gentle exit. A secondCtrl-Cwould then terminate the process.Unfortunately we will no longer be able to terminate the thread forcefully, as
Thread.stopis busted Java >20 (see com-lihaoyi/Ammonite#1379), so usingThread.interruptandsys.exitis the best we haveTested manually using
bin/scala. Doesn't work insbt repldue to SBT also intercepting the signal, but that's a separate issue we can follow up later