-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix compiler crash with -Ymagic-offset-header
#24124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @tgodzik ! Could I request for a backport to 3.7.4?
Thanks @tgodzik ! Could I request for a backport to 3.7.4?
I think we'll have an RC2 @WojciechMazur ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Before merging, could you squash and rename the commits? Right now they are not quite informative.
I will do it with the squash on github, it does use the PR description in those cases
Uh oh!
There was an error while loading. Please reload this page.
Fixes #24091
Since
span.startis only valid whenspan.exists, we just check that first before callingspan.startand otherwise fall back to the default code pathHaven't tested it, but from the stack trace it looks like it should fix the problem