-
Notifications
You must be signed in to change notification settings - Fork 1.1k
port scalac and testCompilation aliases to the new build
#24117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems dubious to duplicate the definition of scalac and testCompilation at two places; can't we factor these out? 🥺
Seems dubious to duplicate the definition of
scalacandtestCompilationat two places; can't we factor these out? 🥺
I know, I know. I just duplicated everything when I migrated things because a lot of things are happening everywhere so that when we migrated, I know what happens where, why and how. This build is complex enough already and I want to understand what is happening.
92ce657 to
964380e
Compare
:)