-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Tweak tryParameterless to use readapt #24078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
som-snytt
wants to merge
1
commit into
scala:main
from
som-snytt:issue/21207-parens-nullary-fallback
Open
Tweak tryParameterless to use readapt #24078
som-snytt
wants to merge
1
commit into
scala:main
from
som-snytt:issue/21207-parens-nullary-fallback
+64
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readapt will autoapply if permitted and also warn on migration.
Answers the question at #6955 (comment)
We'll see if it's the right answer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Readapt will autoapply if permitted and also warn on migration.
Fixes #21207
Why was the ticket worth tackling?
I started to look at tickets about overloading, so this is a first step on the journey of understanding the parts involved.
It happens that I backported
tryParameterlessto Scala 2.How I fixed it
There are just two places where it adds parens.
My first attempt was more direct, since I want only a possible warning and parens:
but the tree has an overloaded type.
Why is this PR worth reviewing?
It's a one-line change, so now I'm on pace for 1 LOC/day, which is net zero.
What's the worse that could happen?
The fix is a bit indirect, so it's easy to imagine it breaking under strain.