-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Always traverse Inlined.call in linter #24043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
+143
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it incorrectly only looked at call after typer, but it must also look at call after inlining, for intermediate expansions which are not directly written by user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it incorrectly only looked at call after typer, but it must also look at call after inlining, for intermediate expansions which are not directly written by user.
Fixes #24034
I added names to the iron givens to make it easier to find them in
-Yplain-printeroutput;XXXwas deeply nested in anInlinedtree. The restriction onphaseModewas due to a misunderstanding about inlining.The mechanism of a stack of inlined positions, used to control name look-ups, needs further research or investigation. It's needed for the commented existing test. Speculating that the useful distinction is between the call of a top-most
Inlined(normal code) and anything else (expansions and nested inlining); and the existing heuristic forsummonInline(which performs resolution at expansion).