-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Emit mixin forwarders as ordinary, non-bridge methods again #23942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9c4398f to
fdd15a4
Compare
This reverts commit 700eea7. Forward port of scala/scala@96f844e
This reverts commit 6d0f9ca. Forward port of most commits in scala/scala#8037 Compensate some of the consequences by adding the `MixedIn` flag. In addition to the use seen in the diff in `BCodeHelpers`, the JS backend has an existing test for `isOneOf(Bridge | MixedIn)` which needs this compensation.
This is a forward port of scala/scala@6fc2202 In Scala 2 that commit was reverting a commit that had stopped emitting Java generic signatures. In dotc we never had that logic before, so this is new code.
...ler cannot build everything correctly
373b096 to
f4330f0
Compare
Co-authored-by: Hamza Remmal <hamza@remmal.net>
cec4a04 to
17c93cc
Compare
#23963 it took me all the afternoon yesterday to migrate and update just a little of the CB.
To not stop progress here, I'm rewriting the sbt-bridge changes in a Java 8 syntax.
8ebc65a to
d6e9a75
Compare
d6e9a75 to
aa267b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not None
Should we try backporting it to LTS ? @hamzaremmal ?
This is debatable, I'm more towards not backporting it since 3.3.7 will start emitting code that 3.4.0 doesn't emit.
But that will affect the Play users?
Oh no no no; don't backport this.
It did seem to be a bit risky yeah, thanks for confirming Sebastien!
Lets try to merge again #21890