-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[chore] Fix detecting available nightly versions in bisect script. #23802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Fix detecting available nightly versions in bisect script. #23802
Conversation
...po contains only artifacts published after 2025年08月18日
The intent is to have maven central also accessible via the new repo, I had permission issues when configuring it during Scala Days and I haven't yet fixed them. This should cover for this PR.
The intent is to have maven central also accessible via the new repo, I had permission issues when configuring it during Scala Days and I haven't yet fixed them. This should cover for this PR.
I belive the repo.scala-lang already can delegate to Maven Central for missing artifacts, however, in this case we're extracting the maven-metadata.xml. Before there were any releases made to repo.scala-lang.org it was mirroring the metadata file existing in Maven Central. However, as soon as it started to contain it's own versions it returns its own maven-metadata.xml file containing its published versions, but no releases made to Maven Central. It seems like a valid behaviour to me, that's why we're looking for releases in 2 places. I'm not sure if it's fixable otherwise
However, as soon as it started to contain it's own versions it returns its own maven-metadata.xml file containing its published versions, but no releases made to Maven Central. It seems like a valid behaviour to me, that's why we're looking for releases in 2 places. I'm not sure if it's fixable otherwise
I'll let you see the maven-metadata.xml file once I fix what I intend to fix. Maybe I'm mistaken, but it should cover everything. Note that at the moment the scala repo doesn't mirror maven central yet as I had to disable it to make it work with the time constraint I had last week.
...rsion to support 3.8 nightlies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardcoding --cli-version=1.9.0 here will always enforce the JVM launcher... which is slightly slower than its native counterparts.
That being said, it does ensure the script will work for everyone. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A potential improvement would be to check for the version of scala-cli being used
This command will print the launcher version, only
scala-cli version --cli-version
And then if it's <1.9.0, print a warning and default to the --cli-version override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you deem it out of scope for this PR, feel free to leave it like this and raise the improvement as an issue.
The new repo contains only artefacts published after 2025年08月18日, we need to parse maven-matadata from the old repository to get the full list of available nightlyies