Enrich and finesse compiler crash reporting #17031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dwijnand merged 3 commits into scala:main from dwijnand:crash-informer

Mar 6, 2023

Merged

Enrich and finesse compiler crash reporting #17031

dwijnand merged 3 commits into scala:main from dwijnand:crash-informer

Mar 6, 2023

Conversation

dwijnand

Copy link

Member

@dwijnand dwijnand commented Mar 1, 2023 •

edited

Loading

Change trytoShow's to not use raw string
Add an enrichedErrorMessage on Run, so to only handle the first exception

Some of the changes from #16685.

dwijnand added 2 commits

March 1, 2023 17:22

@dwijnand


 Change trytoShow's to not use raw string

09b389b

@dwijnand


 Add an enrichedErrorMessage on Run, so to only handle the first excep...

378f5ff

...tion

@dwijnand dwijnand marked this pull request as ready for review

March 2, 2023 08:48

@dwijnand dwijnand requested a review from odersky

March 2, 2023 08:48

@dwijnand dwijnand assigned odersky

Mar 2, 2023

@SethTisue

Copy link

Member

SethTisue commented Mar 2, 2023 •

edited

Loading

This looks like a good core of uncontroversial (I think) yet highly beneficial changes to land.

Perhaps some of the rest of #16685 and/or #16593 could eventually land as separate followup PRs.

cc @robmwalsh

odersky

odersky approved these changes

Mar 6, 2023

View reviewed changes

Copy link

Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Looks like a great improvement!

compiler/src/dotty/tools/dotc/Driver.scala Show resolved Hide resolved

@odersky odersky assigned dwijnand and unassigned odersky

Mar 6, 2023

odersky

odersky requested changes

Mar 6, 2023

View reviewed changes

compiler/src/dotty/tools/dotc/Run.scala Show resolved Hide resolved

@dwijnand


 Unduplicate enrich{,ed}ErrorMessage

099f9f2

Having a same-named enrichement will cause the original to be called
if/when explicit nulls is switched off - which leads to the original
method to be called, meaning an NPE will be thrown.
So, instead, move all the functionality as an extension method, so we
don't need mangled names.

odersky

odersky approved these changes

Mar 6, 2023

View reviewed changes