Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added all missing type annotations. #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dubinsky merged 1 commit into scala:main from dubinsky:version-dependent-types
Jun 20, 2023
Merged

Added all missing type annotations. #675

dubinsky merged 1 commit into scala:main from dubinsky:version-dependent-types
Jun 20, 2023

Conversation

Copy link
Contributor

@dubinsky dubinsky commented Jun 20, 2023

  • introduced ScalaVersionSpecificReturnTypes;
  • split MIMA exclusions by Scala version;
  • removed exclusions that are no longer needed;
  • made Circle CI task names not mention the exact Scala version;
  • provisioned for Scala 2.13-specific code;
  • Scala 2.13- is only Scala 2.12 now that Scala 11 is no longer supported :)
  • marked classes used by the compiler.

Sniper1h reacted with thumbs up emoji
- introduced `ScalaVersionSpecificReturnTypes`;
- split MIMA exclusions by Scala version;
- removed exclusions that are no longer needed;
- made Circle CI task names not mention the exact Scala version;
- provisioned for Scala 2.13-specific code;
- Scala 2.13- is only Scala 2.12 now that Scala 11 is no longer supported :)
- marked classes used by the compiler.
@dubinsky dubinsky marked this pull request as ready for review June 20, 2023 04:45
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @dubinsky!

I'll let @SethTisue also take a look.

dubinsky reacted with rocket emoji
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Copy link
Contributor Author

Thank you, merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

@SethTisue SethTisue SethTisue approved these changes

@ashawley ashawley Awaiting requested review from ashawley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /