-
Notifications
You must be signed in to change notification settings - Fork 93
SI-8834 serialize, sequenceToXML pass all options #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serialize and sequenceToXML recursively call each other but were not passing all formatting options. Fix that.
Blaisorblade
commented
Sep 19, 2014
The change makes sense to me — it's not clear why it was ever otherwise.
It would be cool to have a testcase for this or to extend current ones for that.
Countless Scala noobs have had to apply this fix.
This fixes #38 (I moved the JIRA ticket here).
Apologies for the slow reaction! Thank you very much, @ptwithy! This will ship as v1.0.3, which will be included in Scala 2.11.5
adriaanm
added a commit
that referenced
this pull request
Dec 3, 2014
SI-8834 serialize, sequenceToXML pass all options Fixes #38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SI-8834:
serializeandsequenceToXMLrecursively call each other but were not passing all formatting options. Fix that.