Change apostrophe in error message #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gourlaysama merged 2 commits into scala:1.0.x from egulias:patch-1

Sep 19, 2016

Merged

Change apostrophe in error message #81

gourlaysama merged 2 commits into scala:1.0.x from egulias:patch-1

Sep 19, 2016

Conversation

egulias

Copy link

Contributor

@egulias egulias commented Jul 19, 2016

I'm not sure if this was intentionally left with ' instead of "`" in the closing apostrophe, but just in case it was not I made the PR.
Scala CLA has been signed.

@egulias egulias force-pushed the patch-1 branch from 964f903 to 7eeea94 Compare

July 30, 2016 22:19

@SethTisue

Copy link

Member

SethTisue commented Aug 9, 2016 •

edited

Loading

pairing of with ' is a LaTeX-ism, so it was probably intentional, but that doesn't mean it's desirable. I'd suggest using regular single quote ' instead of. paired ` is a Markdown-ism which isn't any more appropriate here than LaTeX

@egulias

Copy link

Contributor Author

egulias commented Sep 3, 2016

Didn't see the edited comment, I'll change it. Sorry for the delay.

@egulias


 Change apostrophe in error message

3dd55dd

I'm not sure if this was intentionally left with `'` instead of ` in the closing apostrophe, but just in case it was not I made the PR.
Scala CLA has been signed.

@egulias egulias force-pushed the patch-1 branch from 7eeea94 to 3dd55dd Compare

September 4, 2016 10:07

@egulias

Copy link

Contributor Author

egulias commented Sep 4, 2016

Is there a way to relaunch tests? It is a failure with openjdk7 (https://travis-ci.org/scala/scala-parser-combinators/jobs/157424627), an overflow with core dump. I guess it has nothing to do with the actual changes.