-
Notifications
You must be signed in to change notification settings - Fork 131
Fix packrat caching with PagedSeqReader #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #45. The problem was that whenever PagedSeqReader is constructed, source is assigned seq (although lazily) but since PagedSeq is not a subclass of java.lang.CharSequence, an implicit conversion takes place via Predef#SeqCharSequence, creating a new object. The problem is that this happens every time PagedSeqReader#rest or drop is called, breaking packrat caching entirely.
Hi @liskin, good catch, and sorry it took this long to get to it.
It is sad we can't get rid of PagedSeqReader entirely, anything related to PagedSeq seems to cause trouble at some point, but this works well. Thank you for contributing! 🎆
LGTM
gourlaysama
added a commit
that referenced
this pull request
Sep 8, 2015
Fix packrat caching with PagedSeqReader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #45.
The problem was that whenever PagedSeqReader is constructed, source is
assigned seq (although lazily) but since PagedSeq is not a subclass of
java.lang.CharSequence, an implicit conversion takes place via
Predef#SeqCharSequence, creating a new object. The problem is that this
happens every time PagedSeqReader#rest or drop is called, breaking packrat
caching entirely.