Don't check for scala versions anymore for scala native #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Philippus merged 4 commits into scala:main from Philippus:issue-444

Feb 3, 2022

Merged

Don't check for scala versions anymore for scala native #447

Philippus merged 4 commits into scala:main from Philippus:issue-444

Feb 3, 2022

Conversation

Philippus

Copy link

Member

@Philippus Philippus commented Feb 2, 2022 •

edited

Loading

I think this will help solve the empty jars problem in #444. I had to update scala 3.0.2 to 3.1.1 as well to make the build succeed.

@Philippus Philippus force-pushed the issue-444 branch 2 times, most recently from de2d168 to d7ae2c6 Compare

February 2, 2022 20:38

Philippus added 2 commits

February 2, 2022 21:42

@Philippus


 Update scala 3.0.2 to 3.1.1

a48f4d7

@Philippus


 Don't check for scala versions anymore for scala native

d7444e7

@Philippus Philippus force-pushed the issue-444 branch from d7ae2c6 to d7444e7 Compare

February 2, 2022 20:42

@Philippus Philippus requested a review from SethTisue

February 2, 2022 20:48

@SethTisue

Copy link

Member

SethTisue commented Feb 2, 2022

I think it's fine to use Scala 3.1. It means users of our next library version won't be able to use it on Scala 3.0, but I think that's fine, let them move to 3.1. (Scala 3.1.2-RC1 adds -Yscala-release which aims to add this kind of forward-compatibility, but I think it's too new/experimental for us to rely on.)

I think the check for JDK 1.6 can be dropped; we no longer build or test on JDK 6 or 7.

I'm curious if the test := {} is still needed.

Did you look to see if publishLocal publishes non-empty JARs?