Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

for 1.2.x, drop Scala 2.11 support (including Scala Native) #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue wants to merge 3 commits into scala:1.2.x from SethTisue:drop-2.11-support

Conversation

Copy link
Member

@SethTisue SethTisue commented Nov 4, 2020
edited
Loading

Scala Native support could be re-added once SN supports Scala 2.12 and/or 2.13

Scala Native support could be re-added once SN supports Scala
2.12 and/or 2.13
Copy link
Member Author

@Philippus It just seems like a maintenance burden to me. I don't have my heart set on merging this, though. wdyt?

2.11 support would remain in place on the 1.1.x branch

lolgab reacted with thumbs up emoji

Copy link
Member

I'm okay with it, but this will not cause problems for https://github.com/lightbend/ssl-config for example?
If there is an important bugfix we could always backport it to the 1.1.x branch.

Copy link
Member Author

I think ssl-config could themselves be dropping 2.11 support at this point. But anyway yeah exactly, the 1.1.x branch still exists, in the unlikely event we need it.

Copy link
Member Author

SethTisue commented Nov 12, 2020
edited
Loading

Hmm.... 2.13 support for Scala Native support was merged today. I hadn't anticipated that happening so quickly after 2.12 support landed.

So perhaps it would be better to wait a little while longer for a Scala Native release, then redo this PR to drop 2.11 but without dropping Scala Native.

Copy link
Member

Awesome! Good that I stalled on reviewing. ;)

SethTisue reacted with laugh emoji

Copy link
Member Author

okay, closing for now, we can always reopen later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philippus Philippus Philippus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /