Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

adapt to scala/scala#9292 #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SethTisue merged 1 commit into scala:1.2.x from SethTisue:charsequence
Nov 3, 2020
Merged

adapt to scala/scala#9292 #306

SethTisue merged 1 commit into scala:1.2.x from SethTisue:charsequence
Nov 3, 2020

Conversation

Copy link
Member

@SethTisue SethTisue commented Oct 29, 2020

No description provided.

Copy link
Member Author

SethTisue commented Oct 29, 2020
edited
Loading

first commit was a blind stab, second commit was after I looked at it a bit closer. we can squash before merge, if this ends up being merged

Copy link
Contributor

🩸 🔪 🙈

Copy link
Contributor

I would like to make the same offer as posco on twitter ("if you would like me to leave suggestions and comments"), except with puns and emoji.

Copy link
Member Author

two puns please, and a side order of emoji, hold the pickle

Copy link
Member Author

squashed. regardless of what happens to scala/scala#9292, I think this is code improvement and we should just merge it.

@SethTisue SethTisue marked this pull request as ready for review November 3, 2020 18:08
@SethTisue SethTisue merged commit 338ba0b into scala:1.2.x Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Philippus Philippus Philippus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /