-
Notifications
You must be signed in to change notification settings - Fork 131
misc cleanups, go (nearly) warning-free #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SethTisue
SethTisue
force-pushed
the
misc-cleanups
branch
from
October 29, 2020 19:27
373926c to
e97a7fb
Compare
in particular, I've come to really dislike .withoutSuffixFor(JVMPlatform), it makes the root project and the JVM project too easy to confuse with each other
@SethTisue
SethTisue
force-pushed
the
misc-cleanups
branch
from
October 29, 2020 19:31
e97a7fb to
50becd3
Compare
@SethTisue
SethTisue
force-pushed
the
misc-cleanups
branch
from
October 29, 2020 20:18
50becd3 to
19cca8f
Compare
Sorry for not reviewing this. But, it LGTM. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
the commits are probably easier to review individually
note that the build.sh changes enable publishing on Dotty — I don't know why that was disabled before, perhaps inadvertent/historical? if there's some problem, I guess we'll find out when we roll 1.2.0 (whenever that is)