-
Notifications
You must be signed in to change notification settings - Fork 131
issue #242 implementation of repNM for 1.2.x #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3ed6570 to
96acad4
Compare
I have signed the Scala CLA.
shared/src/main/scala/scala/util/parsing/combinator/Parsers.scala
Outdated
Show resolved
Hide resolved
shared/src/main/scala/scala/util/parsing/combinator/Parsers.scala
Outdated
Show resolved
Hide resolved
shared/src/main/scala/scala/util/parsing/combinator/Parsers.scala
Outdated
Show resolved
Hide resolved
fwiw, https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html uses the "n, m" ordering (not "m, n")
I guess the parameters need names, but baking the NM/MN thing into the name of the trait (repMN) isn't necessary, I think? if we have repN, then the other one ought to be repNM, I think, not repMN. but perhaps we could dodge the issue (except in the parameter names) with a name like repRange... or something?
@SethTisue I like repNM, it's pretty compact and intuitive if you know regex.
shared/src/main/scala/scala/util/parsing/combinator/Parsers.scala
Outdated
Show resolved
Hide resolved
34f752a to
a65cbec
Compare
this seems ready for merge once Travis-CI likes it; I think it's failing currently because this fix is needed: scala/scala#8536 — @pgrandjean could you add a commit that makes that change?
34f259f to
a65cbec
Compare
Cleared the travis caches and re-started the build, it's green now.
@SethTisue @Philippus @lrytz thank you!
No description provided.