-
Notifications
You must be signed in to change notification settings - Fork 131
Test locally built scala parser-combinators classes. #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, the scala-parser-combinators classes used to run tests were not the local ones, even though there is no dependency on scala-compiler nor on anything that depends on scala-parser-combinators. After some head-scratching, I discovered scala/scala-xml#20. Now I am even more confused, but at least `fork in Test := true` does prevent this evil classloader magic.
Very sorry about that. I'll add the fork workaround for the black magic to the modules build plugin.
Just a side note: we'll have to debug those issues with classloaders as part of migration of scala compiler to sbt.
adriaanm
added a commit
that referenced
this pull request
Mar 8, 2014
Test locally built scala parser-combinators classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, the scala-parser-combinators classes used to run tests were
not the local ones, even though there is no dependency on scala-compiler
nor on anything that depends on scala-parser-combinators.
After some head-scratching, I discovered scala/scala-xml#20. Now I am even
more confused, but at least
fork in Test := truedoes prevent thisevil classloader magic.