Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Ignore -m option when used #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maskeynihal wants to merge 1 commit into sbimochan:main
base: main
Choose a base branch
Loading
from maskeynihal:master

Conversation

@maskeynihal
Copy link

@maskeynihal maskeynihal commented Nov 1, 2024

  • commit "<commit message>"
  • commit -m "<commit message>"

These two will both gives the same output. -m is ignore.

Motivation

  • The -m option is typically used with the git commit -m command. However, sometimes out of habit, users may mistakenly add -m when using the commit command alone, resulting in an error, as illustrated below.
image

Copy link
Owner

Do you also mistakenly add 'git' in front of 'commit -m' as well? Haha!
What do others say about this graceful fallback?
One con I see is it's adding complexity to code for other future contributors because this script doesn't have any tests.

Copy link
Owner

Meanwhile I'd recommend to use your own fork. I'm unsure how many percentile of the users have this issue.
I'll be adding full tests and setups before merging this to main. Or contributions are of-course welcome. 😀

Copy link
Owner

Ref #29

Copy link
Owner

@maskeynihal please provide tests to cover your changes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbimochan sbimochan Awaiting requested review from sbimochan

At least 1 approving review is required to merge this pull request.

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /