Commit 3fc5985

committed

Merge pull request #6 from DevFactory/release/multiple-code-improvements-fix-2

Multiple code improvements: squid:S00105, squid:S2325, squid:S1481

2 parents 18174c2 + f7c18fe commit 3fc5985Copy full SHA for 3fc5985

File tree

-9

lines changed

-9

lines changed

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,5 @@`
`1`	`1`	`package org.sayem.webdriver.function;`
`2`	`2`
`3`		`-`
`4`		`-import org.openqa.selenium.JavascriptExecutor;`
`5`	`3`	`import org.openqa.selenium.NoAlertPresentException;`
`6`	`4`	`import org.openqa.selenium.WebDriver;`
`7`	`5`
`@@ -14,8 +12,6 @@`
`14`	`12`	`public class IsAlertPresent implements Predicate<WebDriver> {`
`15`	`13`	`@Override`
`16`	`14`	`public boolean test(final WebDriver driver) {`
`17`		`- JavascriptExecutor executor = (JavascriptExecutor) driver;`
`18`		`-`
`19`	`15`	`try {`
`20`	`16`	`driver.switchTo().alert();`
`21`	`17`	`return true;`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,10 +14,10 @@ public class RetryListener implements IAnnotationTransformer {`
`14`	`14`
`15`	`15`	`@Override`
`16`	`16`	`public void transform(ITestAnnotation testannotation, Class testClass,`
`17`		`- Constructor testConstructor, Method testMethod){`
	`17`	`+ Constructor testConstructor, Method testMethod){`
`18`	`18`	`IRetryAnalyzer retry = testannotation.getRetryAnalyzer();`
`19`	`19`
`20`		`- if (retry == null){`
	`20`	`+ if (retry == null){`
`21`	`21`	`testannotation.setRetryAnalyzer(TestNGRetry.class);`
`22`	`22`	`}`
`23`	`23`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public class ScreenshotListener extends TestListenerAdapter {`
`22`	`22`
`23`	`23`	`private static final Logger log = getLogger(ScreenshotListener.class);`
`24`	`24`
`25`		`- private boolean createFile(File screenshot) {`
	`25`	`+ private staticboolean createFile(File screenshot) {`
`26`	`26`	`boolean fileCreated = false;`
`27`	`27`
`28`	`28`	`if (screenshot.exists()) {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ public class Browser extends DelegatingWebDriver`
`22`	`22`	`implements ExplicitWait, SearchScope {`
`23`	`23`
`24`	`24`	`private static final String VALUE2 = "value";`
`25`		`-public static final Logger log = getLogger(Browser.class);`
	`25`	`+public static final Logger log = getLogger(Browser.class);`
`26`	`26`	`private Action action;`
`27`	`27`	`private JavascriptActions javascript;`
`28`	`28`	`private MultiSelect select;`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ public class DatePicker {`
`11`	`11`
`12`	`12`	`private static final String M_D_YYYY = "M/d/yyyy";`
`13`	`13`
`14`		`-public String todayDate() {`
	`14`	`+public String todayDate() {`
`15`	`15`	`LocalDate date = LocalDate.now();`
`16`	`16`	`return date.format(DateTimeFormatter.ofPattern(M_D_YYYY));`
`17`	`17`	`}`

Comments

(0)