Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit f7c18fe

Browse files
author
George Kankava
committed
multiple code improvements: squid:S00105, squid:S2325, squid:S1481
1 parent 0d86717 commit f7c18fe

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed

‎src/main/java/org/sayem/webdriver/function/IsAlertPresent.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package org.sayem.webdriver.function;
22

3-
4-
import org.openqa.selenium.JavascriptExecutor;
53
import org.openqa.selenium.NoAlertPresentException;
64
import org.openqa.selenium.WebDriver;
75

@@ -14,8 +12,6 @@
1412
public class IsAlertPresent implements Predicate<WebDriver> {
1513
@Override
1614
public boolean test(final WebDriver driver) {
17-
JavascriptExecutor executor = (JavascriptExecutor) driver;
18-
1915
try {
2016
driver.switchTo().alert();
2117
return true;

‎src/main/java/org/sayem/webdriver/listeners/RetryListener.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ public class RetryListener implements IAnnotationTransformer {
1414

1515
@Override
1616
public void transform(ITestAnnotation testannotation, Class testClass,
17-
Constructor testConstructor, Method testMethod){
17+
Constructor testConstructor, Method testMethod){
1818
IRetryAnalyzer retry = testannotation.getRetryAnalyzer();
1919

20-
if (retry == null){
20+
if (retry == null){
2121
testannotation.setRetryAnalyzer(TestNGRetry.class);
2222
}
2323
}

‎src/main/java/org/sayem/webdriver/listeners/ScreenshotListener.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class ScreenshotListener extends TestListenerAdapter {
2222

2323
private static final Logger log = getLogger(ScreenshotListener.class);
2424

25-
private boolean createFile(File screenshot) {
25+
private staticboolean createFile(File screenshot) {
2626
boolean fileCreated = false;
2727

2828
if (screenshot.exists()) {

‎src/main/java/org/sayem/webdriver/selenium/Browser.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class Browser extends DelegatingWebDriver
2222
implements ExplicitWait, SearchScope {
2323

2424
private static final String VALUE2 = "value";
25-
public static final Logger log = getLogger(Browser.class);
25+
public static final Logger log = getLogger(Browser.class);
2626
private Action action;
2727
private JavascriptActions javascript;
2828
private MultiSelect select;

‎src/main/java/org/sayem/webdriver/selenium/DatePicker.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public class DatePicker {
1111

1212
private static final String M_D_YYYY = "M/d/yyyy";
1313

14-
public String todayDate() {
14+
public String todayDate() {
1515
LocalDate date = LocalDate.now();
1616
return date.format(DateTimeFormatter.ofPattern(M_D_YYYY));
1717
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /